Add Helm chart linting and snapshot testing #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: Tests won't run in CI until merged to main due to pull_request_target workflow trigger |
sd109
force-pushed
the
feat/helm-ci-improvements
branch
from
98ae09e to
ca5fc0a
Compare
sd109
force-pushed
the
feat/helm-ci-improvements
branch
from
ca5fc0a to
3827d15
Compare
JohnGarbutt
approved these changes
May 22, 2025
Contributor
JohnGarbutt
left a comment
JohnGarbutt
left a comment
There was a problem hiding this comment.
Lets get the tests passing, but I like this approach.
This was referenced Jul 2, 2025
sd109
added a commit
to azimuth-cloud/azimuth
that referenced
this pull request
Jul 3, 2025
Implementation based on azimuth-cloud/cluster-api-janitor-openstack#192 --------- Co-authored-by: Scott Davidson <[email protected]>
This was referenced Jul 8, 2025
sd109
added a commit
to azimuth-cloud/cluster-api-addon-provider
that referenced
this pull request
Jul 10, 2025
Based on azimuth-cloud/cluster-api-janitor-openstack#192 Won't be tested in CI until merged to main due to pull_request_target workflow trigger but have tested each workflow step locally for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation based on azimuth-cloud/capi-helm-charts#546